Feat add model version #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit removes portions of queries that refer to n._to and n._from - cruft from standpoint of the simpler versioning system.
making query formation consistent bug fixes
Use maj1/mdb-test-versioned image to run with test_010mdb_versioned suite
update original test_010mdb to add Model nodes to fixture DB
pulling too hard from docker hub
|
Hit the limit with Docker Hub pulls. |
|
Re-ran each test job individually, and all succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added version-aware queries to mdb.py. Added tests against new docker image maj1/mdb-test-versioned, sample versioned MDB on neo4j 4.4.
For these to work and be backwards-compatible to an unversioned MDB, the MDB must have Model nodes for each model represented. If there are multiple versions of a model in the db, each (model, version) pair must have a Model node, with the 'version' property of the Model node set to the version string. The latest version of a Model is flagged with an 'is_latest' property in the Model node, set to true.
The calling convention in mdb.py is: if the version argument is not present, the operation proceeds on the latest version only; if it is set, it proceeds on that model version; if version = "*", it proceeds across all versions of the given model.
Note - I had to build the test db docker directly on an Ubuntu machine, rather than on my macbook, to get the Github Actions ubuntu runner to run it. There were platform mismatches that that seemed to fix.